summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Lidén Borell <samuel@kodafritt.se>2014-02-15 18:55:11 +0100
committerSamuel Lidén Borell <samuel@kodafritt.se>2014-02-15 18:55:11 +0100
commit23c4e9661d07eed26a147f9fa3474f9c7c54b795 (patch)
tree73fea3c0ce95849227d7242907e85ec83730b0f9
parent63cd175f96569c30b55387d9b964cd348a647e1b (diff)
downloadfribid-23c4e9661d07eed26a147f9fa3474f9c7c54b795.tar.gz
fribid-23c4e9661d07eed26a147f9fa3474f9c7c54b795.tar.bz2
fribid-23c4e9661d07eed26a147f9fa3474f9c7c54b795.zip
Remove some old TODO comments
Regarding the "length checks" TODO, the length check is now done in objInvoke() which in turn calls objInvokeSafe().
-rw-r--r--plugin/npobject.c3
-rw-r--r--plugin/plugin.h1
2 files changed, 0 insertions, 4 deletions
diff --git a/plugin/npobject.c b/plugin/npobject.c
index 7ba0619..b5d99c6 100644
--- a/plugin/npobject.c
+++ b/plugin/npobject.c
@@ -173,8 +173,6 @@ static bool objInvokeSafe(PluginObject *this, const char *name,
return convertStringZToVariant(value, result);
} else if (IS_CALL_2("StoreCertificates", STRING, STRING)) {
// Store a certificate chain
- // TODO check string lengths
-
const NPString *type_nps = &NPVARIANT_TO_STRING(args[0]);
bool type_is_p7c = (type_nps->utf8length == 3 &&
!strncmp(type_nps->utf8characters, "p7c", 3));
@@ -192,7 +190,6 @@ static bool objInvokeSafe(PluginObject *this, const char *name,
return ok;
} else if (IS_CALL_0("GetLastError")) {
// Get last error
- // TODO fix code duplication!
INT32_TO_NPVARIANT((int32_t)this->plugin->lastError, *result);
return true;
}
diff --git a/plugin/plugin.h b/plugin/plugin.h
index 03ca494..30eb97c 100644
--- a/plugin/plugin.h
+++ b/plugin/plugin.h
@@ -98,7 +98,6 @@ bool sign_setParam(Plugin *plugin, const char *name, const char *value);
int sign_performAction(Plugin *plugin, const char *action);
int sign_performAction_Authenticate(Plugin *plugin);
int sign_performAction_Sign(Plugin *plugin);
-// TODO more functions...
void regutil_setParam(Plugin *plugin, const char *name, const char *value);
void regutil_initRequest(Plugin *plugin, const char *type);